Fix turtle speaker upgrade's missing texture #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sprite was not registered into the atlas, meaning it rendered the missing texture instead.
This ensures we will not get missing texture errors in the future, and allows resource pack artists to use additional textures.
|
Can one of the admins verify this patch? |
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…urtle-speaker-model Fix turtle speaker upgrade's missing texture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two parts to this commit: a simple fix, and a more comprehensive fix. Feel free to cherry pick one as desired.
The simple fix (2e7302e) simply adds the speaker texture to the texture sprite. As of MinecraftForge/MinecraftForge@7892ca9 the texture will not be automatically detected as resources are only loaded once.
The more comprehensive fix (80b1170) will automatically extract textures from the upgrade models. This has the advantages that we don't need to register textures ourselves, and also allows resource pack makers to use different texture names for upgrades.